fix: use userinfo() with okta and don't try decoding as json...

dpgaspar · Dec 7, 2024 · cc41ee6 · cc41ee6
1 parent fab9013
commit cc41ee6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/docs/security.rst b/docs/security.rst
@@ -407,7 +407,7 @@ To customize the userinfo retrieval, you can create your own method like this::
         response: Dict[str, Any]
     ) -> Dict[str, Any]:
         if provider == "okta":
-            me = sm.oauth_remotes[provider].get("userinfo")
+            me = sm.oauth_remotes[provider].userinfo()
             return {
                 "username": "okta_" + me.data.get("sub", ""),
                 "first_name": me.data.get("given_name", ""),

diff --git a/flask_appbuilder/security/manager.py b/flask_appbuilder/security/manager.py
@@ -659,8 +659,7 @@ def get_oauth_user_info(
             return {"username": "openshift_" + data.get("metadata").get("name")}
         # for Okta
         if provider == "okta":
-            me = self.appbuilder.sm.oauth_remotes[provider].get("userinfo")
-            data = me.json()
+            data = self.appbuilder.sm.oauth_remotes[provider].userinfo()
             log.debug("User info from Okta: %s", data)
             if "error" not in data:
                 return {