Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queue to exit when mq processing msg panic #1057

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

nattygui
Copy link
Contributor

  1. Causing the queue goroutine to exit processing msg panic
    img_v3_027e_2e865395-f8a8-49cc-ae74-53f5c87b164g

  2. Then should add recover() function to prevent exit and continue process the msg.

image

@nattygui nattygui changed the title fix queue to exit when mq processing msg panic fix: queue to exit when mq processing msg panic Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (299b3ec) 53.10% compared to head (b67726d) 53.22%.

Files Patch % Lines
pkg/client/rocketmq/push_consumer.go 18.75% 11 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   53.10%   53.22%   +0.11%     
==========================================
  Files         206      206              
  Lines       11535    11544       +9     
==========================================
+ Hits         6126     6144      +18     
+ Misses       4941     4934       -7     
+ Partials      468      466       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sysulq sysulq merged commit 07fa9b2 into douyu:master Jan 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants