Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not record ip in metric #1016

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: do not record ip in metric #1016

merged 1 commit into from
Oct 13, 2023

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Oct 13, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live October 13, 2023 07:49 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #1016 (2ec359a) into master (ceb40fa) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   53.09%   53.22%   +0.13%     
==========================================
  Files         206      206              
  Lines       11538    11535       -3     
==========================================
+ Hits         6126     6140      +14     
+ Misses       4943     4927      -16     
+ Partials      469      468       -1     
Files Coverage Δ
pkg/server/xecho/middleware.go 74.68% <100.00%> (+2.73%) ⬆️

... and 3 files with indirect coverage changes

@sysulq sysulq enabled auto-merge (squash) October 13, 2023 07:53
@sysulq sysulq disabled auto-merge October 13, 2023 07:55
@sysulq sysulq merged commit 933ca67 into master Oct 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants