Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve otel with resource #1009

Merged
merged 1 commit into from
Oct 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions pkg/core/xtrace/jaeger/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@
package jaeger

import (
"context"

"github.com/douyu/jupiter/pkg"
"github.com/douyu/jupiter/pkg/conf"
"github.com/douyu/jupiter/pkg/xlog"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/exporters/jaeger"
"go.opentelemetry.io/otel/sdk/resource"
tracesdk "go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.12.0"
semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
"go.opentelemetry.io/otel/trace"
)

Expand Down Expand Up @@ -55,19 +57,30 @@ func (config *Config) Build() trace.TracerProvider {
// Create the Jaeger exporter
exp, err := jaeger.New(jaeger.WithCollectorEndpoint(jaeger.WithEndpoint(config.Endpoint)))
if err != nil {
xlog.Jupiter().Panic("new jaeger", xlog.FieldMod("build"), xlog.FieldErr(err))
xlog.Jupiter().Panic("new jaeger", xlog.FieldErr(err))
return nil
}

resource, err := resource.New(context.TODO(),
resource.WithHost(),
resource.WithFromEnv(),
resource.WithTelemetrySDK(),
resource.WithAttributes(
semconv.ServiceNameKey.String(config.Name),
),
)
if err != nil {
xlog.Jupiter().Panic("new resource", xlog.FieldErr(err))
return nil
}

tp := tracesdk.NewTracerProvider(
// Set the sampling rate based on the parent span to 100%
tracesdk.WithSampler(tracesdk.ParentBased(tracesdk.TraceIDRatioBased(config.Sampler))),
// Always be sure to batch in production.
tracesdk.WithBatcher(exp),
// Record information about this application in an Resource.
tracesdk.WithResource(resource.NewSchemaless(
semconv.TelemetrySDKLanguageGo,
semconv.ServiceNameKey.String(config.Name),
)),
tracesdk.WithResource(resource),
)
otel.SetTracerProvider(tp)
return tp
Expand Down
Loading