Skip to content

Commit

Permalink
Remove CI lint and check diff jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
dougsong committed Aug 11, 2023
1 parent 4a83201 commit 4b1918e
Showing 1 changed file with 86 additions and 86 deletions.
172 changes: 86 additions & 86 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,92 +35,92 @@ jobs:
do_not_skip: '["workflow_dispatch", "schedule", "push"]'


lint:
runs-on: ubuntu-22.04
needs: detect-noop
if: needs.detect-noop.outputs.noop != 'true'

steps:
- name: Checkout
uses: actions/checkout@v2
with:
submodules: true

- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: ${{ env.GO_VERSION }}

- name: Find the Go Build Cache
id: go
run: echo "cache=$(make go.cachedir)" >> $GITHUB_OUTPUT

- name: Cache the Go Build Cache
uses: actions/cache@v3
with:
path: ${{ steps.go.outputs.cache }}
key: ${{ runner.os }}-build-lint-${{ hashFiles('**/go.sum') }}
restore-keys: ${{ runner.os }}-build-lint-

- name: Cache Go Dependencies
uses: actions/cache@v3
with:
path: .work/pkg
key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}
restore-keys: ${{ runner.os }}-pkg-

- name: Vendor Dependencies
run: make vendor vendor.check

# We could run 'make lint' but we prefer this action because it leaves
# 'annotations' (i.e. it comments on PRs to point out linter violations).
- name: Lint
uses: golangci/golangci-lint-action@v3
with:
version: ${{ env.GOLANGCI_VERSION }}

check-diff:
runs-on: ubuntu-22.04
needs: detect-noop
if: needs.detect-noop.outputs.noop != 'true'

steps:
- name: Checkout
uses: actions/checkout@v2
with:
submodules: true

- name: Setup Go
uses: actions/setup-go@v2
with:
go-version: ${{ env.GO_VERSION }}

- name: Install goimports
run: go install golang.org/x/tools/cmd/goimports

- name: Find the Go Build Cache
id: go
run: echo "cache=$(make go.cachedir)" >> $GITHUB_OUTPUT

- name: Cache the Go Build Cache
uses: actions/cache@v3
with:
path: ${{ steps.go.outputs.cache }}
key: ${{ runner.os }}-build-check-diff-${{ hashFiles('**/go.sum') }}
restore-keys: ${{ runner.os }}-build-check-diff-

- name: Cache Go Dependencies
uses: actions/cache@v3
with:
path: .work/pkg
key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}
restore-keys: ${{ runner.os }}-pkg-

- name: Vendor Dependencies
run: make vendor vendor.check

- name: Check Diff
run: make check-diff
# lint:
# runs-on: ubuntu-22.04
# needs: detect-noop
# if: needs.detect-noop.outputs.noop != 'true'
#
# steps:
# - name: Checkout
# uses: actions/checkout@v2
# with:
# submodules: true
#
# - name: Setup Go
# uses: actions/setup-go@v2
# with:
# go-version: ${{ env.GO_VERSION }}
#
# - name: Find the Go Build Cache
# id: go
# run: echo "cache=$(make go.cachedir)" >> $GITHUB_OUTPUT
#
# - name: Cache the Go Build Cache
# uses: actions/cache@v3
# with:
# path: ${{ steps.go.outputs.cache }}
# key: ${{ runner.os }}-build-lint-${{ hashFiles('**/go.sum') }}
# restore-keys: ${{ runner.os }}-build-lint-
#
# - name: Cache Go Dependencies
# uses: actions/cache@v3
# with:
# path: .work/pkg
# key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}
# restore-keys: ${{ runner.os }}-pkg-
#
# - name: Vendor Dependencies
# run: make vendor vendor.check
#
# # We could run 'make lint' but we prefer this action because it leaves
# # 'annotations' (i.e. it comments on PRs to point out linter violations).
# - name: Lint
# uses: golangci/golangci-lint-action@v3
# with:
# version: ${{ env.GOLANGCI_VERSION }}
#
# check-diff:
# runs-on: ubuntu-22.04
# needs: detect-noop
# if: needs.detect-noop.outputs.noop != 'true'
#
# steps:
# - name: Checkout
# uses: actions/checkout@v2
# with:
# submodules: true
#
# - name: Setup Go
# uses: actions/setup-go@v2
# with:
# go-version: ${{ env.GO_VERSION }}
#
# - name: Install goimports
# run: go install golang.org/x/tools/cmd/goimports
#
# - name: Find the Go Build Cache
# id: go
# run: echo "cache=$(make go.cachedir)" >> $GITHUB_OUTPUT
#
# - name: Cache the Go Build Cache
# uses: actions/cache@v3
# with:
# path: ${{ steps.go.outputs.cache }}
# key: ${{ runner.os }}-build-check-diff-${{ hashFiles('**/go.sum') }}
# restore-keys: ${{ runner.os }}-build-check-diff-
#
# - name: Cache Go Dependencies
# uses: actions/cache@v3
# with:
# path: .work/pkg
# key: ${{ runner.os }}-pkg-${{ hashFiles('**/go.sum') }}
# restore-keys: ${{ runner.os }}-pkg-
#
# - name: Vendor Dependencies
# run: make vendor vendor.check
#
# - name: Check Diff
# run: make check-diff

unit-tests:
runs-on: ubuntu-22.04
Expand Down

0 comments on commit 4b1918e

Please sign in to comment.