Fix broken events in Bridgeless mode (React Native New Architecture)

[robik]

This PR fixes broken event emitting in React Native new architecture.

EDIT: This is breaking change, and mostly acts as a preview. I will try to come up with a solution for it if time allows.

This is a partial solution, and requires:

• chore: improve bridgeless interop layer compatibility #2290 for this package
• fix: AppRegistry not callable from Native in bridgeless facebook/react-native#46480 for react native (note you'll need to build from source)

[pigeonmal]

I have test this patch with new arch react native 0.75.3. But i got this kotlin error :
MusicService.kt error: unresolved reference: reactContext

[robik]

I have test this patch with new arch react native 0.75.3. But i got this kotlin error : MusicService.kt error: unresolved reference: reactContext

This probably is caused by the fact that the old RN is used (RN patch was not applied or it was not built from source)

[pigeonmal]

Thanks for your reply, and how can i fix that ?

My steps :

• Install 0.75.3 RN
• install rntp ( "react-native-track-player": "git+https://[email protected]/behenate/react-native-track-player.git#@behenate/improve-bridgeless-support )
• Add patchs of here
• install and build
  I checked node_modules source code and patched are working

[lovegaoshi]

see https://github.com/lovegaoshi/RNTPExampleNewArch/tree/fix
ur either missing https://github.com/lovegaoshi/RNTPExampleNewArch/blob/830428365aac927e2f3c984fe414469b6d4c88af/android/settings.gradle#L9
or
https://github.com/lovegaoshi/RNTPExampleNewArch/blob/fix/patches/react-native%2B0.75.3.patch

[pigeonmal]

Yes the only file i not have the same as you is settings.gradle (i have the default one). If add your modifications, i have an other error :

`Could not determine the dependencies of task ':react-native:packages:react-native:ReactAndroid:hermes-engine:configureBuildForHermes'.

Could not create task ':react-native:packages:react-native:ReactAndroid:hermes-engine:installCMake'.
Could not find sdkmanager executable.`

[lovegaoshi]

so u r having compilation issues. if u dont add that in, ie. https://reactnative.dev/contributing/how-to-build-from-source, ur not compiling RN and not applying any changes. this is outside the scope of this PR and u should seek help in the general RN community.
im not going to pretend compiling RN is easy. its a PITA and im too sane now to troubleshoot someone elses env setup.

[Noitham]

Now that 0.76 has been released, should we pick up again on this PR?

Ref. #2290

[lovegaoshi]

with 0.76.1 released these prs can finally be tested. for the lazy folks my example is now upgraded to newarch + 0.76.1.
im still waiting for expo 52 to actually test newarch myself, but with possibly many of my used libs breaking, im not spending a whole lot of effort here.

[syed-shoaib-ali]

Now that 0.76 has been released, should we pick up again on this PR?

Ref. #2290

in new architecture the app crashes while setupPlayer so will this PR covered that issue as well?

[lovegaoshi]

like i said my example app runs. so presumably yes.

…

On Thu, Oct 31, 2024, 11:59 AM Syed Shoaib Ali ***@***.***> wrote: Now that 0.76 has been released, should we pick up again on this PR? Ref. #2290 <#2290> in new architecture the app crashes while setupPlayer so will this PR covered that issue as well? — Reply to this email directly, view it on GitHub <#2370 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZMOVVTUY5Q3D56O6YSFBJ3Z6J4XXAVCNFSM6AAAAABOFEDBAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGYYTIOJVHA> . You are receiving this because you commented.Message ID: ***@***.*** com>

[ducatti007]

Merge that for god sake!