Evan redis #2
Open
Evan redis #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8-shen
reviewed
Jan 2, 2019
| }, | ||
| }; | ||
|
|
||
| class myredis { |
There was a problem hiding this comment.
1.class推荐以大驼峰命名
myredis这个名称不像是一个官方库，建议follow官方库的名称或直接叫'redis'
| this.myRedis = Redis.createClient(this.config.client.port, this.config.client.host, | ||
| {connect_timeout: this.config.client.connect_timeout} | ||
| ); | ||
| this.myRedis.on("error", function(err) { |
| console.log('redis error',err) | ||
| }); | ||
|
|
||
| this.myRedis.on('ready', function () { |
There was a problem hiding this comment.
1.对于connect一个redis，是异步过程，可以先返回promise，在onready里面resolve比较合理
eg:
return new Promise((resolve,reject)=>{ this.myRedis.on('ready',()=>{ resolve({ code:1, message: ''connected'' }) }) })
2.如果确实想使用现在的方式，可以对于redis的ready事件提供一个钩子
| return this.myRedis; | ||
| } | ||
|
|
||
| set (key, value, callback) { |
There was a problem hiding this comment.
不推荐使用callback的方式进行返回，可以使用promise进行处理，方便外部使用async await
| } | ||
| } | ||
|
|
||
| get (key,callback) { |
There was a problem hiding this comment.
不推荐使用callback的方式进行返回，可以使用promise进行处理，方便外部使用async await
| }); | ||
| } | ||
|
|
||
| setex (key, maxAge, value, callback) { |
There was a problem hiding this comment.
不推荐使用callback的方式进行返回，可以使用promise进行处理，方便外部使用async await
| @@ -0,0 +1,56 @@ | |||
| let redis = require('../plugin/redis/redis'); | |||
There was a problem hiding this comment.
需要进行代码格式化，提高可读性，现在这样在github是不易于阅读的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
欧巴 我push 了