Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add params global.port for dify #75

Merged
merged 3 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/dify/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.3.0
version: 0.3.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.6.2"
appVersion: "0.6.3"

dependencies:
- name: redis
Expand Down
18 changes: 9 additions & 9 deletions charts/dify/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ global:
# Set to the latest version of dify
# Check the version here: https://github.com/langgenius/dify/releases
# If not set, Using the default value in Chart.yaml
tag: "0.6.2"
extraBackendEnvs:
- name: SECRET_KEY
value: "generate your own one"
- name: LOG_LEVEL
value: "DEBUG"
- name: VECTOR_STORE
value: "milvus"
tag: "0.6.3"
extraBackendEnvs:
- name: SECRET_KEY
value: "generate your own one"
- name: LOG_LEVEL
value: "DEBUG"
- name: VECTOR_STORE
value: "milvus"

ingress:
enabled: true
Expand All @@ -50,7 +50,7 @@ To upgrade app, change the value of `global.image.tag` to the desired version
```
global:
image:
tag: "0.6.2"
tag: "0.6.3"
```

Then upgrade the app with helm command
Expand Down
2 changes: 1 addition & 1 deletion charts/dify/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Create the name of the service account to use
{{- end }}

{{- define "dify.baseUrl" -}}
{{ if .Values.global.enableTLS }}https://{{ else }}http://{{ end }}{{.Values.global.host}}
{{ if .Values.global.enableTLS }}https://{{ else }}http://{{ end }}{{.Values.global.host}}{{ if .Values.global.port }}:{{.Values.global.port}}{{ end }}
{{- end }}

{{/*
Expand Down
2 changes: 2 additions & 0 deletions charts/dify/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ fullnameOverride: ""

global:
host: "chart-example.local"
# Change this is your ingress is exposed with port other than 443, 80, like 8080 for instance
port: ""
LeoQuote marked this conversation as resolved.
Show resolved Hide resolved
enableTLS: false
image:
tag: ""
Expand Down
Loading