Add support for OpenAI style function call support #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punitvara
force-pushed
the
1376-openaifnsupport
branch
from
fa0efbd to
900db31
Compare
User should pass OpenAI style dictionary of function and it should be internally converted to same json schema as callable function (dottxt-ai#1376)
rlouf
force-pushed
the
1376-openaifnsupport
branch
from
900db31 to
26f9f21
Compare
RobinPicard
reviewed
Feb 17, 2025
There was a problem hiding this comment.
It looks fine to me, but could you do the following please?
- Update the type-hinting and docstrings in the function to include it as a possible input type
- Update the documentation in
docs/reference/generation/json.mdto specify that this schema_object type is available, explain the necessary dict structure and link to the Openai documentation about it - Write a test for this new type in
tests/generate/test_generate.py
|
yes sure. @RobinPicard will update PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User should pass OpenAI style dictionary of function and it should be internally converted to same json schema as callable function