Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of audio transformers #1317

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

g-prz
Copy link
Contributor

@g-prz g-prz commented Dec 3, 2024

This PR proposes an integration of audio transformers into outlines framework (#1270)

@g-prz g-prz force-pushed the integrate-transformers-audio branch 2 times, most recently from cbbd9a7 to 3bedff8 Compare December 3, 2024 21:34
@g-prz
Copy link
Contributor Author

g-prz commented Dec 4, 2024

Hey @rlouf 🙋‍♂️
I'm not sure, but it seems that the runner disk is full and qwen2-audio files are taking a bit too much space, I can try to find a gguf version or maybe a smaller model? Wdyt?

@rlouf
Copy link
Member

rlouf commented Dec 4, 2024

We generally use HF's internal testing models which are much smaller, see the other tests. Can you try to find if there is one for audio?

@g-prz
Copy link
Contributor Author

g-prz commented Dec 4, 2024

Hey @rlouf
Running into something funny, I have test_generate_text[model_transformers_audio-beam_search] that fails, after investigation the instantiation of the beam_search sampler with default param beams to 1 leads to a greedy sampler in hugging face transformers which leads to not calling _beam_search down to _reorder_cache that is not implemented for Qwen2...

To fix it, we could split the parametrization of test_generate_text with beam_search separated from greedy and multinomial so that we can pass more than one head to beam search and not fall into greedy sampler case

@g-prz g-prz force-pushed the integrate-transformers-audio branch from 2bbead1 to d7d6b65 Compare December 11, 2024 11:35
@g-prz
Copy link
Contributor Author

g-prz commented Dec 11, 2024

Hey @rlouf
I updated test_generate_text
I have 95% coverage, the missing parts are in case of import errors (not sure we want to modify the test env to have the coverage) or processor with no tokenizer, to what extend do you want to increase the coverage?
Otherwise good for review on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants