Filter out input ids not being used in inference. Fixes issue #1294 #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyank9320
changed the title
priyank9320
changed the title
rlouf
reviewed
Dec 4, 2024
| @@ -110,6 +111,9 @@ def process_logits( | |||
| allowed_tokens = self.guide.get_next_instruction(guide_state).tokens.to( | |||
| mask.device, non_blocking=True | |||
| ) | |||
| allowed_tokens = allowed_tokens[ | |||
There was a problem hiding this comment.
Is it a safe assumption or is there a more direct way to get this information?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the below error which arises when using outlines with Llama-3.2-11B-Vision model:
which arises because the Llama vision processor includes the image token (id 128256) which is not used during inference but this gets included in the
allowed_tokenstensor while the logits don't have any value for this index. Fixes issue #1294