Skip to content

调整 Token 过期判断条件,依据一些实践,expires=0时,token已经过期。 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vicenteyu
Copy link

@vicenteyu vicenteyu commented May 13, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved token expiration handling to ensure tokens are considered expired exactly at their expiration time.

Copy link

coderabbitai bot commented May 13, 2025

Walkthrough

The update adjusts the logic in the IsExpired() method of the token result class, changing the expiration check from a strict greater-than to a greater-than-or-equal-to comparison. This alteration ensures that tokens are considered expired precisely at their expiration time.

Changes

File Change Summary
WebApiClientCore.Extensions.OAuths/TokenResult.cs Modified the IsExpired() method to use a >= comparison for token expiration timing.

Poem

A token’s life, now finely tuned,
Expires on time, not late or soon.
With “greater than or equal,” we draw the line,
Precision in code—oh, how divine!
Now every hop and every leap,
Tokens rest when time runs deep.
🕰️🐇

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
WebApiClientCore.Extensions.OAuths/TokenResult.cs (2)

76-79: Consider using UTC time for more reliable token expiration checks

While the current implementation works correctly, consider using DateTime.UtcNow instead of DateTime.Now for both the token creation time (line 15) and the expiration check. This would make the code more robust in scenarios involving different time zones or server time changes.

-        private readonly DateTime createTime = DateTime.Now;
+        private readonly DateTime createTime = DateTime.UtcNow;

         public virtual bool IsExpired()
         {
-            return DateTime.Now.Subtract(this.createTime) >= TimeSpan.FromSeconds(this.Expires_in);
+            return DateTime.UtcNow.Subtract(this.createTime) >= TimeSpan.FromSeconds(this.Expires_in);
         }

76-79: Add validation for negative or zero expiration values

Consider adding validation for the Expires_in property. A zero or negative value might lead to tokens that are always expired, which could be intentional (as per the PR description for expires=0) but might also be due to errors for negative values.

         public virtual bool IsExpired()
         {
+            // Handle explicitly the case where Expires_in is 0 or negative
+            if (this.Expires_in <= 0)
+            {
+                return true;
+            }
             return DateTime.Now.Subtract(this.createTime) >= TimeSpan.FromSeconds(this.Expires_in);
         }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfafcbe and 3bc3ab6.

📒 Files selected for processing (1)
  • WebApiClientCore.Extensions.OAuths/TokenResult.cs (1 hunks)
🔇 Additional comments (1)
WebApiClientCore.Extensions.OAuths/TokenResult.cs (1)

78-78: Approval for modified expiration check logic

Changing from > to >= is a good adjustment. This ensures that tokens are considered expired exactly at their expiration time rather than only after it has passed, which is the correct behavior according to the PR objective. This is especially important when expires=0, as the token should be treated as already expired.

@vicenteyu
Copy link
Author

screenshot-20250513-145846
screenshot-20250513-145715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant