Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Calendar) add AdditionalHeaders Parameter #4673 #4674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

densen2014
Copy link
Member

@densen2014 densen2014 commented Nov 16, 2024

(Calendar) 日历组件, 周视图添加附加列, 显示例如时间刻度

Summary of the changes (Less than 80 chars)

周视图添加附加列

Description

fixes #4673

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Introduce an AdditionalHeaders parameter to the Calendar component, allowing users to add custom headers in the week view.

Copy link

sourcery-ai bot commented Nov 16, 2024

Reviewer's Guide by Sourcery

This PR adds support for additional header columns in the Calendar component's week view. The implementation adds a new AdditionalHeaders parameter that accepts an array of strings, which are rendered as extra columns before the weekday headers.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added support for additional header columns in the Calendar week view
  • Added new AdditionalHeaders parameter of type string[]
  • Created RenderAddHeader RenderFragment to display additional header columns
  • Modified week view table header to conditionally render additional columns
  • Additional headers are displayed with responsive behavior (hidden on small screens)
src/BootstrapBlazor/Components/Calendar/Calendar.razor
src/BootstrapBlazor/Components/Calendar/Calendar.razor.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

bb-auto bot commented Nov 16, 2024

Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang November 16, 2024 02:02
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @densen2014 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide documentation for the new AdditionalHeaders parameter and include a demo showing its usage.
  • The PR checklist is incomplete - please review and check all relevant items, particularly regarding documentation and demo requirements.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.97%. Comparing base (624ade0) to head (24c0dd3).

Files with missing lines Patch % Lines
...BootstrapBlazor/Components/Calendar/Calendar.razor 53.84% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4674      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.01%     
==========================================
  Files         620      620              
  Lines       27428    27435       +7     
  Branches     3929     3931       +2     
==========================================
+ Hits        27424    27429       +5     
- Misses          4        5       +1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant