Allow Redundant Paths to Consider Indels #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the redundant path purger could only remove SNPs, this allows it to call paths like A -> B -> F / A->C->D->E->F as redundant, simplifying the graph quite a bit. Changes include: * Make PathWithOrientation class to be internal to the assembly * Remove redundant null check on pass graph * Allow paths to converge if they have different lengths but wind up at same end node * Verified that the paths not only end on the same node, but also approach it from the same direction The checking for loops needs to be much faster than it is.
e.g. A->B->C->D overlaps with E->F->G->C->D so C should be preserved even if not part of the best path as it may be part of other paths.
With the new pruning techniques several tests are expected to fail. The tests are a complicated construction, so for now I am just going to write new ones, rather than modify the old ones to work at present.
Not working yet, but this needs to eventually pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the redundant path purger could only remove SNPs, this allows
it to call paths like A -> B -> F / A->C->D->E->F as redundant,
simplifying the graph
quite a bit.
Changes include:
same end node
approach it from the same direction
The checking for loops needs to be much faster than it is.