Skip to content

Add tests for public API surface of BitmapSizeOptions, cleanup the class #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Apr 7, 2025

Description

Adds test for the entire public API surface of BitmapSizeOptions.

Beyond that, the following has been code:

  • Updated xml doc to reflect the state of things (there were several incorrect claims that are correct in the official documentation / and also now proven via the unit tests, especially the rotation stuff)
  • Uses auto-init properties now to allow for the field to be readonly after creation.
  • The namespace has been flattened as in all new PRs. This is a separate commit to allow for easy review.

Customer Impact

Better codegen and test coverage on public surface.

Regression

No.

Testing

Local build, unit tests.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners April 7, 2025 08:46
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 78.62595% with 28 lines in your changes missing coverage. Please review.

Project coverage is 11.49764%. Comparing base (3cc9d57) to head (7aa4fea).
Report is 7 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10713         +/-   ##
===================================================
+ Coverage   11.17950%   11.49764%   +0.31813%     
===================================================
  Files           3314        3315          +1     
  Lines         665182      665206         +24     
  Branches       74668       74668                 
===================================================
+ Hits           74364       76483       +2119     
+ Misses        589525      587331       -2194     
- Partials        1293        1392         +99     
Flag Coverage Δ
Debug 11.49764% <78.62595%> (+0.31813%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant