Messagebox object support #10213
Open
Messagebox object support #10213
+705
−695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a method to the MessageBox class, that enables the developer to show not just strings, but any object.
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
@dotnet-policy-service agree |
|
This requires API review. Make a commit that contains only the suggested change, do some testing. It crashes when the object is null. Why only this override? |
lindexi
reviewed
Jan 2, 2025
| /// Displays a message box with the string representation of the specified object. | ||
| /// </para> | ||
| /// </devdoc> | ||
| public static MessageBoxResult Show(object messageBoxObject) |
There was a problem hiding this comment.
Sorry, I do not think it is the good design. Because this override do as public static MessageBoxResult Show(string messageBoxText) can do, and this override hide the implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10212
Description
Adding a method to the MessageBox class, that enables the developer to show not just strings, but any object.
Customer Impact
Very little impact, it saves ".ToString()" if you want to show an object in a MessageBox.
Testing
None 💀
Risk
Don't think there's any risk.
Microsoft Reviewers: Open in CodeFlow