Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCleanUp] Addressing SA warnings Part 4 #10126

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Nov 27, 2024

Description

This work is a part of our initiative to set code-style guidelines, align WPF and WinForms, and ensure PR standards with respect to styles. This in turn will help us in better maintainability and readability of the repo overall. The changes follow up from the PR #10080 and references to the issue #10017.

The current changes addresses the following Errors/Warnings in the src folder of WPF:

  • SA1001: The spacing around a comma is incorrect.
  • SA1005: A single-line comment within a C# code file does not begin with a single space.
  • SA1014: An opening generic bracket within a C# element is not spaced correctly.
  • SA1027: The code contains a tab or space character which is inconsistent.
  • SA1028: A line of code ends with a space, tab, or other whitespace characters before the end of line character(s).
  • SA1121: The code uses one of the basic C# types, but does not use the built-in alias for the type.
  • SA1129: A value type was constructed using the syntax new T().

A good way to go about reviewing this is to go commit by commit which pans over individual errors/warnings, and hence easing out the overall understanding. Majority of the changes here are whitespace/new line changes.

Customer Impact

None

Regression

None

Testing

Local Build Pass
The current set of changes looks fairly mechanical and probably don't need a Test Pass, but these set of PRs can be clubbed to do so at a later stage.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 self-assigned this Nov 27, 2024
@harshit7962 harshit7962 requested review from a team as code owners November 27, 2024 13:36
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 27, 2024
himgoyalmicro
himgoyalmicro previously approved these changes Dec 9, 2024
Copy link
Contributor

@himgoyalmicro himgoyalmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit7962 harshit7962 merged commit 78d7e1f into dotnet:main Jan 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in test pass PR metadata: Label to tag PRs, to facilitate with triage Status:Committed Status:Completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants