-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReadOnlySpan<HwndWrapperHook> instead of a temporary heap array #10008
Open
h3xds1nz
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:hwnd-wrapper-stuff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
October 28, 2024 15:58
dotnet-policy-service
bot
added
PR
metadata: Label to tag PRs, to facilitate with triage
Community Contribution
A label for all community Contributions
labels
Oct 28, 2024
I would avoid doing such changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids creation of temporary heap array when initiating
HwndWrapper
, contributing to startup performance.""
withstring.Empty
to use singletons in the API calls.AppDomain.CurrentDomain.FriendlyName
#8567 has optimized this to at least be just 1 call per invocation but could be zero after 1st retrieval, really).HWND
struct as a bonus (one of many, this one is unsed and also not particularly perfect).Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build, app run.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow