Restore "Use Data Bound Items" support in ListBox/ComboBox Smart Tags #13552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#13228 ## Root Cause The `ListBox` and `ComboBox` Smart Tag panels no longer displayed the "Use Data Bound Items" checkbox in .NET 5+ because the logic responsible for detecting and handling data binding (previously in `ListControlBoundActionList`) was removed and replaced with a simplified `ListControlUnboundActionList`. This stripped out support for toggling between bound and unbound modes, as well as the associated UI elements and property editing. ## Proposed changes - Reintroduce `BoundMode`, `DataSource`, `DisplayMember`, `ValueMember`, and `BoundSelectedValue` properties. - Conditionally show data-bound or unbound actions in the Smart Tag panel based on the control's current binding state. - Preserve existing "Edit Items..." dialog behavior for unbound scenarios. ## Customer Impact Developers using the WinForms Designer in .NET 5+ will be able to configure data binding for `ListBox` and `ComboBox` controls through the Smart Tag UI. ## Regression? - No ## Risk - Minimal ## Screenshots ### Before ### After ## Test methodology - Manual ## Test environment(s) - 10.0.100-preview.6.25272.112
|
Drafted because resources need to be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13228
Root Cause
The
ListBoxandComboBoxSmart Tag panels no longer displayed the "Use Data Bound Items" checkbox in .NET 5+ because the logic responsible for detecting and handling data binding (previously inListControlBoundActionList) was removed and replaced with a simplifiedListControlUnboundActionList. This stripped out support for toggling between bound and unbound modes, as well as the associated UI elements and property editing.Proposed changes
BoundMode,DataSource,DisplayMember,ValueMember, andBoundSelectedValueproperties.Customer Impact
Developers using the WinForms Designer in .NET 5+ will be able to configure data binding for
ListBoxandComboBoxcontrols through the Smart Tag UI.Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow