-
Notifications
You must be signed in to change notification settings - Fork 569
dotnet-svcutil test: fix ParamsFiles and typereuse cases #5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imcarolwang
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
imcarolwang:svcutil_FixNet60Tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+285
−511
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
22534fa
dotnet-svcutil test: fix ParamsFiles and typereuse cases
imcarolwang 53ce7b8
Update test to use default target framework instead of update to use …
imcarolwang ba13aab
rebase and fix test failure due to product upgrade.
imcarolwang 4e9ba9c
Rebase and update test baselines.
imcarolwang c818691
Fix test baseline due to prodcut upgrade and add netstandard20 typere…
imcarolwang b722c75
Update test project to reference csproj instead of compiled assembly
imcarolwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...elines/NetStandard20TypeReuse/TypeReuseClient/ServiceReference/dotnet-svcutil.params.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"providerId": "Microsoft.Tools.ServiceModel.Svcutil", | ||
"version": "99.99.99", | ||
"options": { | ||
"inputs": [ | ||
"$testCasesPath$/wsdl/TypeReuseSvc.wsdl" | ||
], | ||
"namespaceMappings": [ | ||
"*, ServiceReference" | ||
], | ||
"outputFile": "Reference.cs", | ||
"references": [ | ||
"$TEMP$NetStandard20TypeReuse//TypeReuseClient//bin//Debug//netstandard2.0//TypesLib.dll", | ||
"System.Runtime, {System.Runtime, 99.99.99}", | ||
"System.Runtime.Serialization.Primitives, {System.Runtime.Serialization.Primitives, 99.99.99}" | ||
], | ||
"targetFramework": "netstandard2.0", | ||
"typeReuseMode": "All" | ||
} | ||
} |
7 changes: 4 additions & 3 deletions
7
...amsFiles_SDK_TFM/TFnet5_0/TFnet5_0.csproj → ...se/TypeReuseClient/TypeReuseClient.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
...les_SDK_TFM/TFnet5_0/TFnet5_0.params.json → ...Baselines/ParamsFiles/elm/elm.params.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
src/dotnet-svcutil/lib/tests/Baselines/ParamsFiles_SDK_TFM/TFnet5_0/TFnet5_0.cs
This file was deleted.
Oops, something went wrong.
12 changes: 0 additions & 12 deletions
12
...dotnet-svcutil/lib/tests/Baselines/ParamsFiles_SDK_TFM/TFnetcoreapp3_1/TFnetcoreapp3_1.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes:
This list determines the version of WCF packages added to the user's project. If the detected target framework matches any item in the list, the latest WCF package version (8.x) will be added; otherwise, WCF 4.10.x packages will be added.
This change may require a separate PR, but it's included here because the current wcf.git code base uses the 10.0 SDK for test compilation and execution. As a result, test scenarios with the default target framework unexpectedly added the WCF version 4.10.x references, causing numerous baseline mismatch test failures.