Exclude active document from C# completion's related files #7809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Nov 20, 2024
dibarbet
approved these changes
Nov 20, 2024
| // The Roslyn related document service would return the active document as related file to itself | ||
| // if the code contains reference to the types defined in the same document. Skip it so the active file | ||
| // won't be used as additonal context. | ||
| const relatedUri = vscode.Uri.file(filePath); |
There was a problem hiding this comment.
fine with this - but wouldn't it be better to filter on the server (it should know the request document)? Then each client doesn't have to do this
There was a problem hiding this comment.
Yea, I thought about that, but ended up taking this approach because conceptually the server returning active document itself if referenced makes sense and is consistent with other similar Roslyn APIs (like getting all linked document from an ID), different client might want to do something different with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.