Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove scala-tools.org from pom.xml due to shutdown of scala-tools.org repository #1201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

laneser
Copy link
Contributor

@laneser laneser commented Jan 17, 2025

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

ref https://stackoverflow.com/questions/41754260/issues-with-scala-tools-org-and-goodstuff-im

scala-maven-plugin is available on maven central and jcenter.

related issue #1200

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 17, 2025

/AzurePipelines run

@wudanzy wudanzy self-requested a review January 17, 2025 01:41
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wudanzy wudanzy requested a review from SparkSnail January 17, 2025 01:42
@laneser
Copy link
Contributor Author

laneser commented Jan 18, 2025

I tried again and encountered a version mismatch error during the build,
even though it had previously succeeded.

Then resolved the issue by fixing the version, and the build now passes in my environment.
Hope this change will also pass the CI/CD pipeline.

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 18, 2025

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 21, 2025

This is the log. log.txt

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 21, 2025

##[warning].NET 5 has some compatibility issues with older Nuget versions(<=5.7), so if you are using an older Nuget version(and not dotnet cli) to restore, then the dotnet cli commands (e.g. dotnet build) which rely on such restored packages might fail. To mitigate such error, you can either: (1) - Use dotnet cli to restore, (2) - Use Nuget version 5.8 to restore, (3) - Use global.json using an older sdk version(<=3) to build
Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting
##[error]Dotnet command failed with non-zero exit code on the following projects : [
'D:\a\_work\1\s\src\csharp\Microsoft.Spark.Worker.UnitTest\Microsoft.Spark.Worker.UnitTest.csproj'

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 21, 2025

Seems you are only modifying in the Spark 2.4, how about just remove it? Spark 2.4 is too outdated.

@laneser
Copy link
Contributor Author

laneser commented Jan 23, 2025

log.txt

Thanks for the log, I found the error due to daemonWorker listener socket is not ready yet,
So I will add a wait for daemonWorker socket listener ready.

@wudanzy
Copy link
Collaborator

wudanzy commented Jan 27, 2025

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants