File-based apps: handle conversion of custom included item types#54251
Draft
jjonescz wants to merge 1 commit into
Draft
File-based apps: handle conversion of custom included item types#54251jjonescz wants to merge 1 commit into
jjonescz wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to change the default item mapping to include
.dll=Reference(so one could reference DLLs, a common request, by doing#:include /path/to.dll) but realized conversion isn't handling custom item types like that properly, because conversion just copies the#:included items and relies on implicit includes like<Compile Include="**.cs"/>which are in the SDK (but there is of course no implicit<Reference Include="**.dll"/>). This should fix that hole in the project conversion. I will follow up with adding.dll=Referenceto the default mapping next (that will be a simple change).