Improve baselining #47700
Merged
Improve baselining #47700
+204
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mmitche
commented
Mar 18, 2025
mmitche
commented
- Add baseline entries for some typical cases
- Add an option for the baseline entry to specify that assembly versions can vary by revision number. This allow for a generic match on file named with a specific check that major.minor.patch are the same
- Fix up some comments
- Add some more summary info
- Add baseline entries for some typical cases - Add an option for the baseline entry to specify that assembly versions can vary by revision number. This allow for a generic match on file named with a specific check that major.minor.patch are the same
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Pull Request Overview
This PR improves baselining by adding new baseline entries for typical cases and introducing an option to allow assembly version matches with revision-only variance. It also refines reporting details and updates comments for clarity.
- Adds detailed issue count reporting in the comparison report.
- Renames parameters for clarity in package comparison methods.
- Introduces a new baseline property to specify revision-only variance matching.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SourceBuild/content/eng/tools/BuildComparer/Program.cs | Updates to console reporting and renaming of parameters for diff vs. baseline package readers; updated error messages in assembly version comparisons. |
| src/SourceBuild/content/eng/tools/BuildComparer/BaselineEntry.cs | Introduces the AllowRevisionOnlyVariance property and associated regex-based matching logic for assembly version variance. |
Files not reviewed (1)
- eng/vmr-msft-comparison-baseline.json: Language not supported
ViktorHofer
reviewed
Mar 18, 2025
Comment on lines
+59
to
+64
| { | ||
| "issueType": "AssemblyVersionMismatch", | ||
| "descriptionMatch": "Microsoft\\.DotNet\\..*\\.dll", | ||
| "allowRevisionOnlyVariance": true, | ||
| "justification": "Arcade binaries vary build to build." | ||
| }, |
There was a problem hiding this comment.
Not sure about this one. We have assemblies with that prefix in sdk and other repos as well.
There was a problem hiding this comment.
Are you sure? I think those in SDK are all Microsoft.NET
There was a problem hiding this comment.
yes. here's a current list:
Microsoft.DotNet.ApiCompat.Task.dll
Microsoft.DotNet.ApiCompat.Task.resources.dll
Microsoft.DotNet.ApiCompatibility.dll
Microsoft.DotNet.ApiCompatibility.resources.dll
Microsoft.DotNet.ApiSymbolExtensions.dll
Microsoft.DotNet.ApiSymbolExtensions.resources.dll
Microsoft.DotNet.Cli.Utils.dll
Microsoft.DotNet.Cli.Utils.resources.dll
Microsoft.DotNet.Configurer.dll
Microsoft.DotNet.Configurer.resources.dll
Microsoft.DotNet.InternalAbstractions.dll
Microsoft.DotNet.NativeWrapper.dll
Microsoft.DotNet.PackageValidation.dll
Microsoft.DotNet.PackageValidation.resources.dll
Microsoft.DotNet.SdkResolver.dll
Microsoft.DotNet.TemplateLocator.dll
Microsoft.DotNet.TemplateLocator.resources.dll
ViktorHofer
approved these changes
Mar 18, 2025
|
@ViktorHofer Added nuspec comparisons. |
3 tasks
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.