Compare tar.gz files between VMR and current .NET builds #47667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tar.gz comparison, including assembly version comparison. Because our archives are basically always in the same order between base and diff, we avoid a ton of extra very expensive disk write time by finding the common files between base and diff, then reading the base and diff simultaneously, keeping a map of open streams. Every time we read a new common entry, we attempt to compare assembly versions and the remove the streams. This is drastically faster than extracting.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to compare tar.gz archives (in addition to zip archives) between VMR and current .NET builds by comparing both file lists and assembly versions, while also refactoring some common routines.
- Introduces new methods to list tar.gz archive files and compare their assembly versions asynchronously.
- Updates copy stream methods to asynchronous versions and reduces the default parallelism from 16 to 8.
- Refactors file version normalization to support comparisons across different archive formats.
Co-authored-by: Copilot <[email protected]>
akoeplinger
approved these changes
Mar 18, 2025
| } | ||
|
|
||
| /// <summary> | ||
| /// This method is called "USE ALL AVAILABLE MEMORY" |
| private static string RemoveVersionsNormalized(string path) | ||
| { | ||
| string strippedPath = path.Replace("\\", "//"); | ||
| string prevPath = path; |
There was a problem hiding this comment.
nit: this is overwritten on the next line anyway so initializing to path is unnecessary
|
/azp list |
|
CI/CD Pipelines for this repository: |
|
/azp run sdk-unified-build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| /// <summary> | ||
| /// Compare the file lists of packages, identifying missing and extra files. | ||
| /// </summary> | ||
| /// <param name="mapping"></param> |
There was a problem hiding this comment.
Nit, what value do empty doc tags provide? It bloats the code and erodes the value of the actual documentation.
There was a problem hiding this comment.
Mind if I fix this in the next iteration? There are some more tests to add to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tar.gz comparison, including assembly version comparison. Because our archives are basically always in the same order between base and diff, we avoid a ton of extra very expensive disk write time by finding the common files between base and diff, then reading the base and diff simultaneously, keeping a map of open streams. Every time we read a new common entry, we attempt to compare assembly versions and the remove the streams. This is drastically faster than extracting.
Also fixes a bug where version numbers weren't being removed from file paths within nupkgs.