Add baselining mechanism to the build comparison tool#47562
Merged
mmitche merged 1 commit intodotnet:mainfrom Mar 14, 2025
Merged
Add baselining mechanism to the build comparison tool#47562mmitche merged 1 commit intodotnet:mainfrom
mmitche merged 1 commit intodotnet:mainfrom
Conversation
Accepts an optiona; json file with a list of baseline entries. Baseline a few well known items.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a baselining mechanism to the build comparison tool. Key changes include:
- Adding new types (BaselineEntry, Baseline, and associated JSON converter) to support baseline configuration.
- Updating the CLI options and Program.cs to load and apply baselines during asset evaluation.
- Updating the pipeline YAML to pass the baseline file path.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SourceBuild/content/eng/tools/BuildComparer/AssetType.cs | New enum for asset types. |
| src/SourceBuild/content/eng/tools/BuildComparer/Issue.cs | New class representing asset issues with baseline support. |
| src/SourceBuild/content/eng/tools/BuildComparer/AssetMapping.cs | New class for mapping asset details and tracking issues. |
| src/SourceBuild/content/eng/tools/BuildComparer/ComparisonReport.cs | New report class summarizing issues, errors, and baselined items. |
| src/SourceBuild/content/eng/tools/BuildComparer/BaselineEntry.cs | New baseline classes and a regex JSON converter for baseline configuration. |
| src/SourceBuild/content/eng/tools/BuildComparer/IssueType.cs | New enum for issue types. |
| src/SourceBuild/content/eng/tools/BuildComparer/Program.cs | Updated to add CLI options, load baseline file, apply baselining, and update reporting. |
| eng/pipelines/templates/steps/vmr-validate-asset-baseline.yml | Pipeline template updated to include the baseline argument. |
Comments suppressed due to low confidence (1)
src/SourceBuild/content/eng/tools/BuildComparer/Program.cs:50
- The baseline CLI option is marked as required, but the PR description indicates that the baseline file should be optional. Consider setting Required = false.
var baselineArgument = new CliOption<string>("-baseline") { Description = "Path to the baseline build manifest.", Required = true };
akoeplinger
approved these changes
Mar 13, 2025
ViktorHofer
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts an optiona; json file with a list of baseline entries. Baseline a few well known items.