Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 7 paths and add error reporting #5627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Jan 7, 2023

I by mistake compile from x86 dev tools on Windows and that cause silent error failure. Hopefully my error reporting does not clutter code too much.

/cc @MichalStrehovsky

I by mistake compile from x86 dev tools on Windows and that cause silent error failure.
Hopefully my error reporting does not clutter code too much.

/cc @MichalStrehovsky
@kant2002 kant2002 requested a review from a team as a code owner January 7, 2023 12:55
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

core/nativeaot/NativeLibrary/LoadLibrary.c Show resolved Hide resolved
core/nativeaot/NativeLibrary/LoadLibrary.c Show resolved Hide resolved
@kant2002
Copy link
Contributor Author

@MichalStrehovsky can you review again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants