[NativeAOT-LLVM] Enhance unresolved symbol handling #3118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
added
the
area-NativeAOT-LLVM
SingleAccretion
force-pushed
the
Missing-Symbols-Enable-Errors
branch
from
7c75cdf to
5cf9157
Compare
SingleAccretion
commented
Jun 19, 2025
|
|
||
| if ($env:EMSDK_PYTHON) | ||
| { | ||
| # Workaround for https://github.com/dotnet/runtime/issues/116746 |
There was a problem hiding this comment.
(I don't actually know if this actually works, but it seems to have helped. The idea here was that the CI build is picking up system python instead of the emsdk bundled python, and that has some issues.)
|
@dotnet/nativeaot-llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop silently ignoring all unresolved symbols on WASI, warn instead, consistent with Emscripten. Also, respect
TreatWarningsAsErrors.