Escape quotes in MailAddress display name when encoding SMTP headers#128979
Draft
Copilot wants to merge 2 commits into
Draft
Escape quotes in MailAddress display name when encoding SMTP headers#128979Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SmtpClient to support quotes in email DisplayName
Escape quotes in MailAddress display name when encoding SMTP headers
Jun 4, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced Jun 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MailAddress.Encode— the pathSmtpClientuses to writeFrom/To/Cc/etc. headers — wraps the display name in"…"but does not escape embedded", producing an invalid RFC 5322 quoted-string and corrupting the header when aDisplayNamelikeHenry "The Fonz" Winkleris used.MailAddress.ToString()already escapes quotes; only the SMTP send path was missed when quote support was added in #36752.Changes
MailAddress.Encode(ASCII /allowUnicode=truebranch): escape embedded"as\"via.Replace("\"", "\\\""), matchingToString(). The Q-encoded (non-ASCII) branch is unaffected since encoded-words don't use quoted-string syntax.MailAddressEncodeTestfor bothMailAddress.EncodeandMailAddressCollection.Encode, covering ASCII and Unicode-allowed modes.Before vs. after for
new MailAddress("test@example.com", "Henry \"The Fonz\" Winkler").Encode(0, false):