[release/10.0] Update EmsdkPackageVersion to use version from dependency flow#128939
Open
akoeplinger wants to merge 1 commit into
Open
[release/10.0] Update EmsdkPackageVersion to use version from dependency flow#128939akoeplinger wants to merge 1 commit into
akoeplinger wants to merge 1 commit into
Conversation
It got hardcoded a while ago to workaround a build problem. --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> (cherry picked from commit 58f1b03)
Contributor
There was a problem hiding this comment.
Pull request overview
Backports #128261 to release/10.0 by removing the hardcoded EmsdkPackageVersion and instead deriving it from the dependency flow–managed MicrosoftNETCoreAppRefPackageVersion, keeping the emsdk package version aligned with the runtime versioning used by the branch.
Changes:
- Switch
EmsdkPackageVersionfrom a fixed value (10.0.0) to$(MicrosoftNETCoreAppRefPackageVersion). - Add clarifying comments explaining why these versions are sourced from other dependency-flow properties.
lewing
approved these changes
Jun 3, 2026
akoeplinger
added
the
NO-MERGE
Member
Author
|
let's not merge this yet, I think using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #128261 to release/10.0