Skip to content

Early init for FrameworkEventSource #126737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahfalk merged 1 commit into from
Apr 10, 2026
+6 −2
Merged

Early init for FrameworkEventSource #126737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3896,10 +3896,14 @@ internal static void InitializeDefaultEventSources()
return;
}

// NOTE: this define is being used inconsistently. Most places mean just EventPipe support, but then a few places use
// it to mean other aspects of tracing such as these EventSources.
// NOTE: this define is being used inconsistently. Most places mean just EventPipe support, but then a few places use
// it to mean other aspects of tracing such as these EventSources.
#if FEATURE_PERFTRACING
_ = NativeRuntimeEventSource.Log;
// ThreadPoolWorkQueue uses FrameworkEventSource during ThreadPool initialization. If that is the first time
// the FrameworkEventSource is being used, creating it on-demand will acquire the EventListener lock which can deadlock.
// See https://github.com/dotnet/runtime/issues/126591. We avoid that by pre-creating the FrameworkEventSource here.
_ = FrameworkEventSource.Log;
#if !TARGET_BROWSER
_ = RuntimeEventSource.Log;
#endif
Expand Down
Loading