Fix GC write barrier when writing async method return into continuation object#126721
Open
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Open
Fix GC write barrier when writing async method return into continuation object#126721BrzVlad wants to merge 1 commit intodotnet:mainfrom
BrzVlad wants to merge 1 commit intodotnet:mainfrom
Conversation
Previous code was only checking if the type contains GC refs, which means it would fail to add a write barrier if the method returns an object without refs.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing GC write barriers when an interpreted async method returns a reference type whose instance contains no GC pointers (e.g., System.Object, string), but the return value itself is still an object reference that must be stored with a write barrier.
Changes:
- Treat non-value-type async returns as object references and store them via
SetObjectReference(write barrier). - Keep
memmoveGCRefsfor value-type returns that contain embedded GC references; otherwise usememcpyNoGCRefs.
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code was only checking if the type contains GC refs, which means it would fail to add a write barrier if the method returns an object without refs.
Fixes System.Text.Json.Tests random GC crashes