fix ntlm tests on platforms with broken gssapi #123055
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Pull request overview
This PR fixes NTLM authentication tests on platforms with broken GSSAPI implementations (specifically Ubuntu 24) by enabling the managed NTLM implementation for those platforms instead of relying on the native GSSAPI. This allows previously failing or skipped tests to run successfully.
Key changes:
- Introduces a platform-specific flag to enable managed NTLM implementation on Ubuntu 24
- Removes the ActiveIssue attribute that was previously skipping the test on Ubuntu 24+
- Modifies NTLM availability detection to include the managed implementation case
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
|
Can you test with |
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'm a bit silly. I asked for runtime-extra-platforms to test for openSUSE 16 but that's not in main, but in another PR. Wires crossed. We may not need this extra level of testing since we're going to test for it on the other PR. It is fine to wait for and look at the results. It just won't produce the analysis I initially had in mind. |
|
@wfurt -- CI is green. Mark the day! |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
... and use our own managed implementation instead.
fixes #111639
contributes to #122371