Fix windows build #122574
Merged
Fix windows build #122574
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
Author
|
@dotnet-policy-service agree |
dotnet-policy-service
bot
added
the
community-contribution
jkotas
added
area-CodeGen-Interpreter-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
jkotas
approved these changes
Dec 16, 2025
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
This looks fine to me. It matches what we are doing on Unix.
This was referenced Dec 16, 2025
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Dec 16, 2025
Co-authored-by: Jeremy Koritzinsky <[email protected]>
jkotas
reviewed
Dec 16, 2025
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.