Include CMakeConfigureLog in logs artifacts #122537
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
am11
added
area-Infrastructure-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @hoyosjs |
Member
Author
cc @jkoritzinsky, @janvorli those .yaml files are new in logs artifacts. |
3 tasks
Member
|
We're getting AzDO errors emitted whenever the artifacts/obj folder doesn't exist. Can you adjust this to only execute the copy if the artifacts/obj folder exists? |
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
I just noticed that these changes are in eng/common. Can we move them into the global-build-job template? If we do that, then we can probably go back to CopyFiles as we'll nearly always build something native.
Comment on lines
215
to
228
| - task: PythonScript@0 | ||
| displayName: Gather CMakeConfigureLog for publish to artifacts | ||
| inputs: | ||
| scriptSource: inline | ||
| script: | | ||
| import os, shutil, glob | ||
| if os.path.isdir('artifacts/obj'): | ||
| dest = '$(Build.ArtifactStagingDirectory)/artifacts/log/cmake' | ||
| os.makedirs(dest, exist_ok=True) | ||
| for f in glob.glob('artifacts/obj/**/CMakeConfigureLog.yaml', recursive=True): | ||
| shutil.copy(f, dest) | ||
| continueOnError: true | ||
| condition: always() | ||
|
|
Member
There was a problem hiding this comment.
Can we do this with a powershell/bash script?
Removed Python script task that gathers CMakeConfigureLog for artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only capture binlog files in
Publish Logsstep. PR addsCMakeConfigureLog.yamlto helps figuring out the result of introspection.