Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/coreclr/vm/commodule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -295,19 +295,10 @@ extern "C" INT32 QCALLTYPE ModuleBuilder_GetMemberRefOfMethodInfo(QCall::ModuleH
if (!pMeth)
COMPlusThrow(kArgumentNullException);

// Otherwise, we want to return memberref token.
if (pMeth->IsArray())
{
_ASSERTE(!"Should not have come here!");
COMPlusThrow(kNotSupportedException);
}

// TODO: (async) revisit and examine if this needs to be supported somehow
if (pMeth->IsAsyncVariantMethod())
{
_ASSERTE(!"Async variants should be hidden from reflection.");
COMPlusThrow(kNotSupportedException);
}
// Should not have come here.
_ASSERTE(!pMeth->IsArray());
// Async variants should be hidden from reflection.
_ASSERTE(!pMeth->IsAsyncVariantMethod());

if ((pMeth->GetMethodTable()->GetModule() == pModule))
{
Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/vm/runtimehandles.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1863,8 +1863,7 @@ extern "C" void QCALLTYPE RuntimeMethodHandle_StripMethodInstantiation(MethodDes
// async variants for task-returning methods
//
// For {task-returning, async} variants Reflection hands out only the task-returning variant.
// the async varinat is an implementation detail that conceptually does not exist.
// TODO: (async) the filtering may not cover all scenarios. Review and add tests.
// the async variant is an implementation detail that conceptually does not exist.
//
// For generic methods we always hand out an instantiating stub except for a generic method definition
// For non-generic methods on generic types we need an instantiating stub if it's one of the following
Expand Down
245 changes: 0 additions & 245 deletions src/tests/async/reflection/reflection-simple.cs

This file was deleted.

Loading
Loading