Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Dec 12, 2025

This PR reapplies the change in Versions.props from #121307

Somehow, that change was lost in the past month.

I am also adding a comment to ensure someone doesn't revert the intentional change to use explicit versions for all 4 MSBuild properties and use a reference to the "main" property.

Notes

This is an infra change as this change produces no differences in the runtime build.

There are also no differences in source-build as we currently have a patch that sets these properties to explicit versions: https://github.com/dotnet/installer/blob/release/8.0.1xx/src/SourceBuild/patches/runtime/0002-Update-MSBuild-dependencies.patch

With this fix, we will be able to remove the source-build patch.

@NikolaMilosavljevic NikolaMilosavljevic requested review from agocke and Copilot and removed request for Copilot December 12, 2025 18:50
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 12, 2025
@NikolaMilosavljevic NikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label Dec 12, 2025
@teo-tsirpanis teo-tsirpanis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 12, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@NikolaMilosavljevic NikolaMilosavljevic added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 13, 2025
@NikolaMilosavljevic NikolaMilosavljevic changed the title Use explicit versions for MSBuild properties [release/8.0-staging] Use explicit versions for MSBuild properties Dec 13, 2025
@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Dec 13, 2025

Some failures in browser-wasm tests are unrelated.

Also failing in other PRs, i.e. #122199 with the same errors.

Likely due to a warning in Send to Helix step: /__w/1/s/.packages/microsoft.dotnet.helix.sdk/8.0.0-beta.25562.3/tools/dotnet-cli/DotNetCli.targets(5,5): warning : Unable to resolve download link from feed https://dotnetbuilds.blob.core.windows.net/public; Response status code does not indicate success: 409 (Public access is not permitted on this storage account.). [/__w/1/s/src/libraries/sendtohelixhelp.proj]

@NikolaMilosavljevic
Copy link
Member Author

@hoyosjs @jkoritzinsky who can help merge this? I don't have permissions to merge on red. Test failures are unrelated and repro in other PRs.

@jkoritzinsky
Copy link
Member

/ba-g failed during the macos13 brownout.

@jkoritzinsky jkoritzinsky merged commit 2064f12 into dotnet:release/8.0-staging Dec 15, 2025
165 of 203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants