Merge JIT/Regression tests into merged wrapper assemblies #121078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
test-enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates JIT regression tests by removing over 1000 individual project files and merging test sources into wrapper assemblies based on their build configurations (DebugType and Optimize settings). The changes also include namespace updates to match test names, addition of OuterLoop attributes to test methods, and correction of a typo in the test wrapper generator.
- Removal of standalone .csproj files for single-file tests without references
- Introduction of merged runner projects grouping tests by build configuration
- Namespace standardization to use test names instead of generic names like "Test" or "DefaultNamespace"
Reviewed Changes
Copilot reviewed 300 out of 2177 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple .csproj files | Removed individual project files for tests being merged into wrapper assemblies |
| Multiple .cs test files | Updated namespaces from generic names to specific test names (e.g., "Test" → "b45270") |
| Multiple .cs test files | Added [OuterLoop] attribute to test methods with CLRTestPriority=1 |
| b16102.cs | Deleted test file validating Main method discovery in internal class |
| b41391.csproj, b37598.csproj, b36472.csproj, b16423.csproj | Added CoreCLRTestLibrary project reference |
| Multiple .cs files using TestLibrary | Simplified TestLibrary.PlatformDetection references to PlatformDetection with using directive |
| XUnitWrapperGenerator.cs | Fixed typo in property name: "IsTailcallStress" → "IsTailCallStress" |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… to their own assemblies.
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 29, 2025
Open
EgorBo
approved these changes
Nov 6, 2025
Member
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
Fine to me unless someone from @dotnet/jit-contrib has objections
Member
Author
|
/ba-g win-arm64 timeouts from when the queue was down. |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Nov 12, 2025
Test merging in dotnet#121078 caused us to start compiling this test again. We were not compiling it because more than 64k fields hits CodeView limitations in LF_STRUCTURE/LF_CLASS (can't have more than 65534 _introduced fields_). We assert and crash compilation. CoreCLR has it's own limitation of 65535 fields, including inherited, but not counting `object.m_pEEType` (that doesn't exist in CoreCLR CoreLib). This changes the test to not have a class with > 65535 introduced fields. This avoids the CodeView assert. We still don't generate correct CodeView for bigger classes. Not sure if it's worth adding blocking. We could block loading such types but 65534 is an odd number and CodeView is an odd reason.
MichalStrehovsky
added a commit
that referenced
this pull request
Nov 12, 2025
Test merging in #121078 caused us to start compiling this test again. We were not compiling it because more than 64k fields hits CodeView limitations in LF_STRUCTURE/LF_CLASS (can't have more than 65534 _introduced fields_). We assert and crash compilation. CoreCLR has it's own limitation of 65535 fields, including inherited, but not counting `object.m_pEEType` (that doesn't exist in CoreCLR CoreLib). This changes the test to not have a class with > 65534 introduced fields. This avoids the CodeView assert. We still don't generate correct CodeView for bigger classes. Not sure if it's worth adding blocking. We could block loading such types but 65534 is an odd number and CodeView is an odd reason. Cc @dotnet/ilc-contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #120992, this PR works to remove the number of projects in the src/tests tree.
It removes project files for projects in the JIT/Regressions tree that have one source file and no references.
New merged runner projects are introduced to group the sources of the old projects by their DebugType and Optimize settings to preserve the interesting elements of the code.
Additionally, this PR removes a test that validates that we can find a Main method in an internal class (not a particularly useful test nowadays). It also moves a number of checks that cover the whole body of a test into a ConditionalFact.
This PR removes a little over 1000 project files from the JIT/Regression tree, reducing the number of projects in the src/tests tree by nearly 10%.
Part of the continuing effort to get us to a point where we don't need separate inner test builds and the cost of building src/tests multiple times is less than the cost of marshalling the bits from different jobs.