Add support for passing 128 and 32 bit HFA args to call stubs on arm64 #121037
+1,630
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpreter call stubs were missing support for HFA 128 bit args passing. That was causing a lot of failures in the HardwareIntrinsics coreclr tests on macOS arm64. With this change, the results basically match the x64 Windows.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing 128-bit homogeneous floating-point aggregate (HFA) arguments in Q registers on ARM64, which was previously missing from the interpreter call stubs. This change resolves failures in HardwareIntrinsics CoreCLR tests on macOS ARM64 by enabling proper handling of Vector128 types passed as function arguments.
Key Changes:
- Added new
FPReg128routine type to handle 128-bit floating-point register arguments - Implemented Q register load/store routines in ARM64 assembly (both MASM and GAS syntax)
- Enhanced argument processing logic to detect and route 128-bit HFA arguments appropriately
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/coreclr/vm/callstubgenerator.h | Moved RoutineType enum earlier in class definition and added FPReg128 type along with tracking field and method declarations |
| src/coreclr/vm/callstubgenerator.cpp | Added Q register routine tables, implemented GetFPReg128RangeRoutine(), and updated argument processing to handle 128-bit float arguments |
| src/coreclr/vm/arm64/asmhelpers.asm | Added ARM64 MASM assembly routines for loading/storing Q registers (128-bit SIMD registers) |
| src/coreclr/vm/arm64/asmhelpers.S | Added ARM64 GAS assembly routines for loading/storing Q registers (128-bit SIMD registers) |
kg
reviewed
Oct 23, 2025
kg
reviewed
Oct 23, 2025
Open
3 tasks
janvorli
changed the title
kg
reviewed
Oct 24, 2025
kg
reviewed
Oct 24, 2025
kg
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter call stubs were missing support for HFA 128 bit and 32 bit args passing. That was causing a lot of failures in the HardwareIntrinsics coreclr tests on macOS arm64.
With this change, the results basically match the x64 Windows.