Skip to content

Refactor SQLDateTime constants #120996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor SQLDateTime constants #120996

wants to merge 3 commits into from

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Oct 22, 2025 •
edited
Loading

  • Rename constants to use PascalCase instead of prefixed s_ names.
  • Use constants instead of static readonly fields
  • Use properties instead of static readonly fields for computed values.

Diffs

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 22, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 22, 2025

Tagging subscribers to this area: @roji, @SamMonoRT
See info in area-owners.md if you want to be subscribed.

@MihuBot MihuBot mentioned this pull request Oct 22, 2025
Open
@xtqqczze xtqqczze mentioned this pull request Oct 23, 2025
Open
This was referenced Oct 25, 2025
Open
Open
@MihuBot MihuBot mentioned this pull request Oct 25, 2025
Open
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 25, 2025

@MihuBot

@MihuBot MihuBot mentioned this pull request Oct 25, 2025
Open
@roji
Copy link
Member

roji commented Oct 25, 2025

/cc @cheenamalhotra @David-Engel

@xtqqczze xtqqczze marked this pull request as ready for review October 25, 2025 17:50
@build-analysis build-analysis bot mentioned this pull request Oct 25, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area-System.Data community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @roji