[release/10.0] [mono][aot] Increase the max symbol size #120295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Long symbol names were truncated, leading to duplicate names in the generated assembly file. This was making the compiler fail due to duplicate symbol names.
github-actions
bot
requested review from
steveisok and
vitek-karas
as code owners
This was referenced Oct 1, 2025
rbhanda
added
Servicing-approved
BrzVlad
approved these changes
Oct 8, 2025
steveisok
approved these changes
Oct 8, 2025
vitek-karas
approved these changes
Oct 8, 2025
|
/ba-g llvm known failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120256 to release/10.0
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2530461
This is a more aggressive fix on top of #119202 which proved to be insufficient when doing more testing with the maui rc2 workload.
/cc @BrzVlad
Customer Impact
Maui application can fail to build due to crash in the aot compiler. This would happen if some symbol is too long, which could happen more commonly if special characters are involved in the application, since they have longer encoding.
Regression
Testing
Tested locally with repro project.
Risk
Low. The change just increases the size of a local buffer used in various places in the compiler.