fix SBOM issues for runtime #113400
Closed
fix SBOM issues for runtime #113400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 25, 2025 16:14
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix SBOM generation issues for runtime by modifying the pipeline configuration. The key changes include disabling SBOM configuration at the job template level, introducing an explicit variable to disable SBOM, and adding a new step to generate SBOM using an external template.
Comments suppressed due to low confidence (1)
eng/pipelines/official/jobs/prepare-signed-artifacts.yml:14
- [nitpick] Consider using consistent naming conventions for SBOM-related settings. For instance, align the casing of 'enableSbom' with 'DISABLE_SBOM' by renaming it to 'disableSbom' to improve clarity.
enableSbom: false
|
Tagging subscribers to this area: @dotnet/area-meta |
hoyosjs
reviewed
Mar 12, 2025
This was referenced Mar 12, 2025
hoyosjs
reviewed
Mar 12, 2025
hoyosjs
approved these changes
Mar 12, 2025
Open
3 tasks
|
I am closing this PR. I have created a new PR #113463 by forking the runtime repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue dotnet/arcade#15562
Description
This PR solves the SBOM generation issue in the runtime repo