[mono] IL Strip make sure the MemoryStream is disposed #112142
+25
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
force-pushed
the
dispose-memorystream
branch
from
47b7aa6 to
1b49249
Compare
steveisok
approved these changes
Feb 4, 2025
pavelsavara
reviewed
Feb 5, 2025
| } | ||
|
|
||
| private static void ZeroOutMethodBody(ref MemoryStream memStream, int methodSize, int actualLoc, int headerSize) | ||
| private static void ZeroOutMethodBody(MemoryStream memStream, int methodSize, int actualLoc, int headerSize) |
There was a problem hiding this comment.
Mapping the region as Span and then Span.Clear will be cheaper than renting new buffer + copy.
There was a problem hiding this comment.
I might be missing something but why are we using a copied MemoryStream at all rather than just directly writing to the FileStream?
akoeplinger
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.