[release/9.0-staging] Include PDB for all TfmRuntimeSpecificPackageFile #112139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Previously this would only include the PDB for the primary output which missed any other additions to TfmRuntimeSpecificPackageFile - such as those from references or packages.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
ViktorHofer
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111879 to release/9.0-staging
/cc @ericstj
Customer Impact
Missing symbols for System.Diagnostics.EventLog.Messages.dll. This is a resource library that doesn't contain code. In the past we told customers to ignore it, but it's better to just fix it. I investigated and found the root cause for this - it's a low risk fix, we should just do it.
Regression
Testing
Build and examine symbols package. Validate with symchk.
I believe the reason our current symbols validation tests provided by Arcade miss this is because they validate on the build machine instead of after we've built the product. Will discuss with @hoyosjs to see if there's an opportunity here.
Risk
Very low - including symbols in symbol package, no product changes. If it builds it's good.