Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Change were libClang.so is found when generating Android aot offsets #111426

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

steveisok
Copy link
Member

Since we bumped the NDK in dotnet/dotnet-buildtools-prereqs-docker#1278, libClang.so is no longer found in the place we expect. As a result, the android aot offsets won't be generated and the dedicated CI leg will fail.

This change fixes the path.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Build failure blocking 9.0. Marking as tell-mode.
If you can, please target release/9.0 instead of staging.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jan 14, 2025
@steveisok steveisok changed the base branch from release/9.0-staging to release/9.0 January 14, 2025 19:08
…, libClang.so is no longer found in the place we expect. As a result, the android aot offsets won't be generated and the dedicated CI leg will fail.

This change fixes the path.
@steveisok steveisok force-pushed the fix-android-offset-leg-9 branch from 9e29014 to 5079ce7 Compare January 14, 2025 19:20
@carlossanlop
Copy link
Member

The affected leg is passing now: runtime (Build android-x64 release MonoAOTOffsets)

Merging.

@carlossanlop carlossanlop merged commit 63cb882 into dotnet:release/9.0 Jan 14, 2025
72 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants