JIT: Consolidate block pred iterator logic

[amanasifkhalid]

Move most of the nested iterator class logic in PredEdgeList/PredBlockList to a generic base class, and implement subclasses that specify the yield type (flow edge or basic block) and whether edits are allowed. This allows us to add a pred edge iterator that tolerates edits with minimal code duplication.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[amanasifkhalid]

From the TP diffs, I suspect MSVC isn't devirtualizing the operator* calls, though it probably makes sense to just move this method to the subclasses entirely, and remove the IteratorType template variable.