[release/8.0] Use JS interop to get full NativeName, DisplayName
#110221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
This was referenced Nov 27, 2024
|
This PR did not get an approval to get backported. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of ##99956 to release/8.0
Fixes #110035, #44739, #45951 in net8.
Customer Impact
Customers that use net8 don't have full form of
DisplayName,EnglishName, they see e.g.:de (DE)instead ofGerman (Germany). With this change they will be able to see the longer form.Regression
We intentionally shortened
DisplayName,EnglishNameto shrink ICU size and we kept it that way for some time. When we realized that JS API can give WASM app the missing globalization information, we leveraged it to revert the full form ofDisplayName,EnglishName.Testing
CI testing edited in this PR will be asserting this change.
Risk
Medium, this change involves unsafe code, icalls to JS. On the other hand, the backport is 1:1 and the change to net 9 was added relatively early in the release cycle.
I am leaving it as a draft until @lewing approves.