Adopt editor InlinePromptService for documentation comments#84282
Draft
cdblake1 wants to merge 2 commits into
Draft
Adopt editor InlinePromptService for documentation comments#84282cdblake1 wants to merge 2 commits into
cdblake1 wants to merge 2 commits into
Conversation
Replace the grey-text SuggestionService UX for Copilot documentation-comment generation with the editor's InlinePrompt chip: typing `///` shows a "Tab to generate documentation" chip, and accepting it generates the comment and writes it to the buffer. - Remove the grey-text path (CopilotGenerateDocumentationCommentProvider, DocumentationCommentSuggestion, StartSuggestionSession). - Extract an editor-agnostic generation core into the Features layer (CopilotDocumentationCommentGenerator, DocumentationCommentEdit) shared by the chip-accept path. - Show the chip only when Copilot is available, the generate-documentation option is enabled, and the file is not Copilot-excluded. - Localize the chip accept text; move the provider id to a constant. - Add tests (InlinePrompt, ApplyEdits, generator) and editor package uptake to consume InlinePromptServiceBase. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9e367b4 to
c496f25
Compare
akhera99
reviewed
Jun 30, 2026
| <PackageVersion Include="System.Threading.Tasks.Dataflow" Version="$(SystemThreadingTasksDataflowVersion)" /> | ||
| <PackageVersion Include="System.Threading.Tasks.Extensions" Version="$(SystemThreadingTasksExtensionsVersion)" /> | ||
| <PackageVersion Include="System.ValueTuple" Version="$(SystemValueTupleVersion)" /> | ||
| <PackageVersion Include="System.ValueTuple" Version="4.6.2" /> |
Member
There was a problem hiding this comment.
This should be reverted and the change should be made in Versions.props
| @@ -918,4 +945,8 @@ | |||
| <value>Chat limit reached, [upgrade now] or wait for the limit to reset.</value> | |||
| <comment>The text surrounded by "[" and "]" characters will be hyperlinked. Please ensure the localized text still has "[" and "]" characters.</comment> | |||
| </data> | |||
| <data name="Generate_documentation" xml:space="preserve"> | |||
| <value>generate documentation</value> | |||
Member
There was a problem hiding this comment.
Suggested change
| <value>generate documentation</value> | |
| <value>Generate documentation</value> |
Author
@dotnet-policy-service agree company="Microsoft" |
…prompt-doc-comment # Conflicts: # eng/Packages.props # eng/Version.Details.props # src/EditorFeatures/TestUtilities/EditorTestCompositions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the grey-text
SuggestionServiceUX for Copilot documentation-comment generation with the editor's InlinePrompt chip. Typing///above a member shows a Tab to generate documentation chip; accepting it generates the comment and writes it to the buffer.Changes
CopilotGenerateDocumentationCommentProvider,DocumentationCommentSuggestion,StartSuggestionSession).CopilotDocumentationCommentGenerator,DocumentationCommentEdit) shared by the chip-accept path.InlinePromptServiceBase.Notes
eng/Packages.propsVS-package version bumps are the editor-uptake values used for local validation, not final coordinated versions.