Extract method cleanup #76550
Merged
Extract method cleanup #76550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 22, 2024
| @@ -151,9 +151,6 @@ | |||
| <data name="Remove_this_qualification" xml:space="preserve"> | |||
| <value>Remove 'this' qualification</value> | |||
| </data> | |||
| <data name="Cannot_determine_valid_range_of_statements_to_extract" xml:space="preserve"> | |||
| <value>Cannot determine valid range of statements to extract</value> | |||
| </data> | |||
There was a problem hiding this comment.
Moved to shared location so we can have one string for VB and C#
|
@JoeRobich @ToddGrun PTAL. This is one of many cleanup PRs i'm making this area as i modernize and simplify the code on the way to some larger user-facing feature refactorings. Note: if you have further suggestions, i'm happy to incorporate them into the followup PRs that are waiting on this one. Thanks! |
CyrusNajmabadi
commented
Jan 2, 2025
| @@ -1113,7 +1113,7 @@ public static void Main() | |||
| p1 = NewMethod(p2); | |||
| } | |||
| private static object NewMethod(object p2) | |||
| private static global::System.Object NewMethod(global::System.Object p2) | |||
There was a problem hiding this comment.
intentional change. EM now calls trhough the correct syntax generator code. but the tests don't actually run the simplification pass (since the tests unfortunately test parts of the api directly).
Open
3 tasks
JoeRobich
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup work in the extract method codebase before doign some more major feature work. I've documented int eh PR what changes i'm making. Should be reviewed with whitespace off.