Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error recovery for null coalescing assignment operator #74218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DoctorKrolic
Copy link
Contributor

Part of compiler part of #73894 (the issue also mentiones operators like +=, -= etc., but I focused only on ??= in this PR to keep it relatively small)

While working on PR I found several inconsistencies in what compiler APIs return in normal and error scenarios. These are marked with // INCONSISTENCY: comments in tests. We need to decide what the desired behavior should be and either:

  • Remove/alter the comments if in the given case the behavior is decided to be expected
  • Make an issue (or several ones) for cases, that can/should be improved ...
  • ... or alternatively fix them in this PR (which I don't like given that the total size of this PR is already around ~1000 lines with actual changes taking just ~20 lines of the codebase)

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner June 30, 2024 10:10
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant